Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend server configuration with compression config #257

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Extend server configuration with compression config #257

merged 6 commits into from
Nov 7, 2023

Conversation

numinnex
Copy link
Contributor

@numinnex numinnex commented Nov 6, 2023

No description provided.

@numinnex numinnex requested review from spetz and hubcio November 6, 2023 19:16
spetz
spetz reviewed Nov 6, 2023
View reviewed changes
server/src/configs/compression_algorithm.rs Outdated Show resolved Hide resolved
server/src/configs/compression_algorithm.rs Outdated Show resolved Hide resolved
@numinnex numinnex requested a review from spetz November 7, 2023 06:36
spetz
spetz reviewed Nov 7, 2023
View reviewed changes
iggy/src/compression.rs Outdated Show resolved Hide resolved
spetz
spetz previously approved these changes Nov 7, 2023
View reviewed changes
hubcio
hubcio reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@hubcio hubcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add warning print if compression is enabled, something like:
Server started with compression enabled, but this feature is not yet implemented!

you can do it in validate() for ServerConfig

iggy/src/compression.rs Outdated Show resolved Hide resolved
hubcio
hubcio reviewed Nov 7, 2023
View reviewed changes
iggy/src/compression.rs Outdated Show resolved Hide resolved
@numinnex
Add negative case tests to CompressionKind conversion, enhance config…
69b9c6d 
… with allow_override flag and improve from_str conversion
@numinnex numinnex requested review from hubcio and spetz November 7, 2023 16:05
hubcio
hubcio reviewed Nov 7, 2023
View reviewed changes
server/src/configs/validators.rs Outdated Show resolved Hide resolved
iggy/src/compression.rs Outdated Show resolved Hide resolved
@numinnex numinnex force-pushed the server_side_compression branch 2 times, most recently from b2b59ce to 105b371 Compare November 7, 2023 18:00
@numinnex
Rename CompressionKind to CompressionAlgorithm and remove not needed …
9ea0d03 
…clone from CompressionConfig validate method
@numinnex numinnex requested a review from hubcio November 7, 2023 18:15
@numinnex numinnex merged commit ab5f3c9 into master Nov 7, 2023
14 checks passed
@numinnex numinnex deleted the server_side_compression branch November 7, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubcio hubcio hubcio approved these changes

@spetz spetz Awaiting requested review from spetz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numinnex @spetz @hubcio